Fix debugger background color #136
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using Firefox in dark mode, `about:blank` has a dark background instead of white. The debugger popup window uses `about:blank`, and as such we get the dark background in the debugger. The text is hard to read then. When a web page does not set the page background color, it is up to the user agent to decide the background color. Firefox lets you configure this background color. So it is a good idea to set the page background color anyway. Ideally, we’d have a dark mode for the debugger too, but that is out of scope for this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Firefox in dark mode,
about:blankhas a dark background instead of white. The debugger popup window usesabout:blank, and as such we get the dark background in the debugger. The text is hard to read then.When a web page does not set the page background color, it is up to the user agent to decide the background color. Firefox lets you configure this background color. So it is a good idea to set the page background color anyway.
Ideally, we’d have a dark mode for the debugger too, but that is out of scope for this PR.
Note to those following along: This PR is included in https://github.com/lydell/browser/tree/safe, which is part of https://github.com/lydell/elm-safe-virtual-dom, but it has nothing to do with “safe virtual DOM” really, it’s just in there because it’s convenient.