Skip to content

Make core capabilities optional on accounts #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

korrat
Copy link

@korrat korrat commented Apr 24, 2024

The spec does not mandate the presence of an "urn:ietf:params:jmap:core" capability on the account objects in the JMAP session. The example does not include this capability either. Additionally, the current implementation does not use these capabilities and only specifies an empty object.

Therefore, this patch makes the properties optional. This means, mujmap can synchronize with a Stalwart mail server.

@sanderhollaar
Copy link

Should PrimaryAccounts at https://github.com/elizagamedev/mujmap/blob/main/src/jmap/session.rs#L41 also be patched?

After applying your patch I still got Failed to read JSON: missing field urn:ietf:params:jmap:core at line 1 column 3952.

I failed to come up with a similar patch so I ended up commenting the lines:

$ grep -nA2 'pub struct PrimaryAccounts' src/jmap/session.rs
41:pub struct PrimaryAccounts {
42-//    #[serde(rename = "urn:ietf:params:jmap:core")]
43-//    pub core: Id,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants