Skip to content

build: roll github actions runners automatically #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jkleinsc
Copy link
Member

@jkleinsc jkleinsc commented Jun 6, 2025

This PR adds roll capability to our github actions runner images. If a new version is available at https://github.com/actions/runner/pkgs/container/actions-runner, create a PR updating the infra repo with the new runner version.

@jkleinsc jkleinsc requested review from a team as code owners June 6, 2025 17:26
@jkleinsc jkleinsc force-pushed the roll-actions-runner branch from 704ccca to b786180 Compare June 6, 2025 17:27
@jkleinsc jkleinsc force-pushed the roll-actions-runner branch from 2c01434 to a647b17 Compare June 10, 2025 20:02
@jkleinsc jkleinsc requested a review from dsanders11 June 10, 2025 20:08
Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment about checking the fetch response but otherwise LGTM. I pushed a commit to favor vi.mocked over as any in tests when possible as it ensures type checking on the return types and can catch mistakes.

};
let manifestList: ManifestList;
try {
const manifestResponse = await fetch(manifestUrl, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should check manifestResponse.ok in case there's a non-200 response code, which won't throw an error here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants