build: roll github actions runners automatically #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkleinsc
force-pushed
the
roll-actions-runner
branch
from
704ccca to
b786180
Compare
dsanders11
requested changes
Jun 7, 2025
| @@ -1,12 +1,12 @@ | |||
| import { Octokit } from '@octokit/rest'; | |||
| import { MAIN_BRANCH, REPOS } from '../constants'; | |||
| import { MAIN_BRANCH, REPOS, WINDOWS_DOCKER_FILE } from '../constants'; | |||
There was a problem hiding this comment.
Suggested change
| import { MAIN_BRANCH, REPOS, WINDOWS_DOCKER_FILE } from '../constants'; | |
| import { MAIN_BRANCH, REPOS } from '../constants'; |
Looks unused in this file.
Comment on lines
+27
to
+45
| export const currentLinuxImages = (content: string) => { | ||
| const matches = content.match(LINUX_IMAGE_REGEX); | ||
| if (!matches || matches.length < 3) { | ||
| return { | ||
| amd64: '', | ||
| arm64: '', | ||
| }; | ||
| } else { | ||
| return { | ||
| amd64: matches[1], | ||
| arm64: matches[2], | ||
| }; | ||
| } | ||
| }; | ||
|
|
||
| export async function getCurrentWindowsRunnerVersion(content: string) { | ||
| return content.match(WINDOWS_RUNNER_REGEX)?.[1]; | ||
| } | ||
|
|
There was a problem hiding this comment.
Test coverage for these two utils would be nice, reviewing raw regexes never feels very effective. 😀
Comment on lines
+32
to
+53
| // Helper to fetch JSON from a URL | ||
| function fetchJson(url: string, headers: Record<string, string> = {}): Promise<any> { | ||
| return new Promise((resolve, reject) => { | ||
| https | ||
| .get(url, { headers }, (res) => { | ||
| let data = ''; | ||
| res.on('data', (chunk) => (data += chunk)); | ||
| res.on('end', () => { | ||
| if (res.statusCode && res.statusCode >= 200 && res.statusCode < 300) { | ||
| try { | ||
| resolve(JSON.parse(data)); | ||
| } catch (e) { | ||
| reject(e); | ||
| } | ||
| } else { | ||
| reject(new Error(`HTTP ${res.statusCode}: ${data}`)); | ||
| } | ||
| }); | ||
| }) | ||
| .on('error', reject); | ||
| }); | ||
| } |
There was a problem hiding this comment.
Any reason we can't just use const resp = fetch(...); if (resp.ok) resp.json(); instead of rolling it ourselves?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds roll capability to our github actions runner images. If a new version is available at https://github.com/actions/runner/pkgs/container/actions-runner, create a PR updating the infra repo with the new runner version.