bin: Expand curl -k to --insecure for visibility

[Zash]

• Should be okay from inside the cluster (harbor and opensearch scripts)
• Should be okay from tests (tests/ and pipeline/)
• No migrations changed

Warning

This is a public repository, ensure not to disclose:

• personal data beyond what is necessary for interacting with this pull request, nor
• business confidential information, such as customer names.

What kind of PR is this?

Required: Mark one of the following that is applicable:

• kind/feature
• kind/improvement
• kind/deprecation
• kind/documentation
• kind/clean-up
• kind/bug
• kind/other

Optional: Mark one or more of the following that are applicable:

Important

Breaking changes should be marked kind/admin-change or kind/dev-change depending on type
Critical security fixes should be marked with kind/security

• kind/admin-change
• kind/dev-change
• kind/security
• [kind/adr](set-me)

What does this PR do / why do we need this PR?

The curl flag -k or --insecure disables certificate validation and such security checks.
The short form especially might be easy to miss during review, so preferrincg the long version is better.

This replaces the short form curl -k with --insecure in order to make it more visible where this is used and obvious what it does.

Information to reviewers

Double check whether the use of --insecure is really warranted in these places.

Checklist

• Proper commit message prefix on all commits
• Change checks:
  • The change is transparent
  • The change is disruptive
  • The change requires no migration steps
  • The change requires migration steps
  • The change updates CRDs
  • The change updates the config and the schema
• Documentation checks:
  • The public documentation required no updates
  • The public documentation required an update - [link to change](set-me)
• Metrics checks:
  • The metrics are still exposed and present in Grafana after the change
  • The metrics names didn't change (Grafana dashboards and Prometheus alerts required no updates)
  • The metrics names did change (Grafana dashboards and Prometheus alerts required an update)
• Logs checks:
  • The logs do not show any errors after the change
• PodSecurityPolicy checks:
  • Any changed Pod is covered by Kubernetes Pod Security Standards
  • Any changed Pod is covered by Gatekeeper Pod Security Policies
  • The change does not cause any Pods to be blocked by Pod Security Standards or Policies
• NetworkPolicy checks:
  • Any changed Pod is covered by Network Policies
  • The change does not cause any dropped packets in the NetworkPolicy Dashboard
• Audit checks:
  • The change does not cause any unnecessary Kubernetes audit events
  • The change requires changes to Kubernetes audit policy
• Falco checks:
  • The change does not cause any alerts to be generated by Falco
• Bug checks:
  • The bug fix is covered by regression tests

[lunkan93]

Nice 👍 We should probably review which of these actually need the --insecure flag at some point..

[rarescosma]

Love it, wish we had a way to disseminate this as a guideline for all future script work: use expanded options in scripts as much as possible.

[Zash]

Also see some more (but less security-related than this) in #2738

wish we had a way to disseminate this as a guideline for all future script work: use expanded options in scripts as much as possible.

This would indeed be nice.