config: Individually configure rollover size for OpenSearch indices #2731
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This is a public repository, ensure not to disclose:
What kind of PR is this?
Required: Mark one of the following that is applicable:
Optional: Mark one or more of the following that are applicable:
Important
Breaking changes should be marked
kind/admin-change
orkind/dev-change
depending on typeCritical security fixes should be marked with
kind/security
What does this PR do / why do we need this PR?
This allows the setting of individual rollover settings for the different indices in OpenSearch. Previously a 5 GB rollover was used for all indices, even though Prometheus alert rules were set to different values. This PR introduces individual settings for the
kubernetes
,kubeaudit
,other
andauthlog
indices. The new default rollover values are based on the existing alerts sizes (slightly smaller).Information to reviewers
The
authlog
alert size was slightly increased because it felt too tiny to set a rollover size to 1 MB, and leaving both alert and rollover at 2 MB felt like it could cause false alerts.One caveat is that the new ISM policy (with smaller size) is only applied after the next rollover, which means that the old size will still be in effect for up to a day.
Question to reviewers: Should this be a
kind/admin-change
and/or have a "Platform Administrator notice" since it changes the configuration file and schema? I'm not sure if my changes here will require any action to be taken by platform admins. Also not sure if this is something that requires a migration.Checklist