Skip to content

Add incomplete integration plugins to metadata.json as skip #16174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2024

Conversation

karenzone
Copy link
Contributor

@karenzone karenzone commented May 21, 2024

Release notes

[rn:skip] to leave this PR out of release notes

Step 1: Move integration plugins

This PR moves logstash-integration-internal and logstash-integration-zeromq plugins to plugins-metadata.json and configure them as default-plugins: false and "skip-list": true to set us up to make the next set of changes to docs tooling.

Next steps

  • ToDo: Change docs tooling to remove skip logic for integration plugins.

Related: elastic/docs-tools#106

@karenzone karenzone self-assigned this May 21, 2024
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @karenzone

Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +444 to +451
"logstash-integration-internal": {
"default-plugins": false,
"skip-list": true
},
"logstash-integration-zeromq": {
"default-plugins": false,
"skip-list": true
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self @karenzone: Currently these two plugins are being skipped because of logic in docs tooling. I'm merging these changes to the skiplist now, even though necessary changes in docs tooling are still under consideration.

@karenzone karenzone merged commit e2acb4d into elastic:main May 31, 2024
6 checks passed
@karenzone karenzone deleted the 106-fix-intg-docgen branch May 31, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants