[9.0] [APM] Fix APM flaky test cleanup logic (#241310) #241362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes elastic#234664 ## Summary This PR fixes a flaky APM test cleanup `after` issue. The test was failing because the after hook was trying to delete the Elasticsearch index apm-8.0.0-transaction without first checking if it exists. This caused an `index_not_found_exception` when the index didn't exist. The test setup in the before hook properly checks if the index exists before deleting it ([lines 35-40](https://github.com/elastic/kibana/compare/main...jennypavlova:kibana:fix-flaky-apm-test-after?expand=1#diff-88902b6ae54830e04bb08653dfda680e427fd98f5d5ae8e5eff6d6dbad455e2cL35-L40)), but the cleanup in the after hook ([line 137](https://github.com/elastic/kibana/compare/main...jennypavlova:kibana:fix-flaky-apm-test-after?expand=1#diff-88902b6ae54830e04bb08653dfda680e427fd98f5d5ae8e5eff6d6dbad455e2cL137)) was missing this same safety check. (cherry picked from commit 8b85ef3)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
CI was triggered for this PR, but this PR targets 9.0 which should not receive a future release. CI is not supported for these branches. Please consult the release schedule, or contact The following branches are currently considered to be open:
|
1 similar comment
|
CI was triggered for this PR, but this PR targets 9.0 which should not receive a future release. CI is not supported for these branches. Please consult the release schedule, or contact The following branches are currently considered to be open:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.0:Questions ?
Please refer to the Backport tool documentation