Skip to content

Conversation

@Bluefinger
Copy link
Contributor

Summary

Fixes one potential bug within #240421, by adding a recursion guard to prevent going any further if we have somehow encountered the same child item more than once. There exists a pathological case where there is an infinite loop due to wonky data for Focused Trace Waterfall, and preventing that means putting a recursion guard on any visited trace item.

This PR is set to draft mode, as I'm currently unable to find a set of data that triggers this case, which I would like to put as a unit test to ensure this pathological case is dealt with for all future work.

How to test

@Bluefinger Bluefinger added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team backport:version Backport to applied version labels v9.3.0 v8.19.7 v9.1.7 v9.2.1 labels Oct 30, 2025
@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!
  • Click to trigger kibana-deploy-cloud-from-pr for this PR!

@Bluefinger
Copy link
Contributor Author

/ci

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #100 / Dataset Quality Dataset quality handles user privileges User can read logs-* User cannot monitor any data stream "before all" hook for "Estimated data are not available due to underprivileged user"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.8MB 2.8MB +47.0B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.19.7 v9.1.7 v9.2.1 v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants