[Discover][Unified Waterfall] Add recursion guard for flattening item map #241329
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Summary
Fixes one potential bug within #240421, by adding a recursion guard to prevent going any further if we have somehow encountered the same child item more than once. There exists a pathological case where there is an infinite loop due to wonky data for Focused Trace Waterfall, and preventing that means putting a recursion guard on any visited trace item.
This PR is set to draft mode, as I'm currently unable to find a set of data that triggers this case, which I would like to put as a unit test to ensure this pathological case is dealt with for all future work.
How to test