Skip to content

ssi_some: fix empty template evaluation to prevent updating fleet health status to degraded #15549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

ssi_some: fix empty template evaluation to prevent updating fleet health status to degraded #15549

wants to merge 5 commits into from

Conversation

brijesh-elastic
Copy link
Collaborator

Proposed commit message

Prevent updating fleet health status to degraded for following packages
when HTTPJSON template value evaluation is empty.

  • akami
  • bitwarden
  • cisco_secure_endpoint (Adding a 'Rate Limit Remaining' header in system test rules to prevent empty template evaluation.)
  • github (Adding a 'Rate Limit Remaining' header in system test rules to prevent empty template evaluation.)
  • google_workspace
  • okta (Adding a 'Rate Limit Remaining' header in system test rules to prevent empty template evaluation.)
  • proofpoint_tap
  • slack
  • ti_misp
  • ti_rapid7_threat_command
  • tines

This change bumps minimum Kibana version to 8.19.4 and 9.0.7 and
adds do_not_log_failure: true in set processors to avoid updating
fleet health status to degraded.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@brijesh-elastic brijesh-elastic self-assigned this Oct 5, 2025
@brijesh-elastic brijesh-elastic requested a review from a team as a code owner October 5, 2025 11:49
@brijesh-elastic brijesh-elastic added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:ti_misp MISP Integration:google_workspace Google Workspace Integration:okta Okta Integration:proofpoint_tap Proofpoint TAP Integration:github GitHub Integration:cisco_secure_endpoint Cisco Secure Endpoint Integration:akamai Akamai (Community supported) Integration:slack Slack Logs (Community supported) Integration:tines Tines (Community supported) Integration:bitwarden Bitwarden Integration:ti_rapid7_threat_command Rapid7 Threat Command (Partner supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels Oct 5, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Oct 5, 2025 •
edited
Loading

🚀 Benchmarks report

Package google_workspace 👍(9) 💚(8) 💔(5)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
gcp 11235.96 8547.01 -2688.95 (-23.93%) 💔
gmail 1390.82 1117.32 -273.5 (-19.66%) 💔
group_enterprise 4901.96 3906.25 -995.71 (-20.31%) 💔
access_transparency 2469.14 1872.66 -596.48 (-24.16%) 💔
vault 7692.31 5208.33 -2483.98 (-32.29%) 💔

Package proofpoint_tap 👍(2) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
message_delivered 3058.1 2570.69 -487.41 (-15.94%) 💔

Package ti_misp 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
threat_attributes 3508.77 2724.8 -783.97 (-22.34%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Oct 6, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @brijesh-elastic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brijesh-elastic brijesh-elastic

Labels
documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:akamai Akamai (Community supported) Integration:bitwarden Bitwarden Integration:cisco_secure_endpoint Cisco Secure Endpoint Integration:github GitHub Integration:google_workspace Google Workspace Integration:okta Okta Integration:proofpoint_tap Proofpoint TAP Integration:slack Slack Logs (Community supported) Integration:ti_misp MISP Integration:ti_rapid7_threat_command Rapid7 Threat Command (Partner supported) Integration:tines Tines (Community supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brijesh-elastic @elasticmachine