Skip to content

[system] [ntp] add ntp data_stream #14982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

[system] [ntp] add ntp data_stream #14982

wants to merge 12 commits into from
+239 −2

Conversation

mykola-elastic
Copy link
Contributor

@mykola-elastic mykola-elastic commented Aug 19, 2025 •
edited
Loading

Proposed commit message

See title.

Checklist

  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Discover

Screenshot 2025-08-19 at 15 36 09

Configuration

Screenshot 2025-08-19 at 15 59 32

@mykola-elastic mykola-elastic self-assigned this Aug 19, 2025
@mykola-elastic mykola-elastic added Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] enhancement New feature or request Integration:system System labels Aug 19, 2025
@mykola-elastic mykola-elastic changed the title [system] [ntp] add ntp data_stream [DRAFt] [system] [ntp] add ntp data_stream Aug 19, 2025
@mykola-elastic mykola-elastic changed the title [DRAFt] [system] [ntp] add ntp data_stream [DRAFT] [system] [ntp] add ntp data_stream Aug 19, 2025
@mykola-elastic mykola-elastic changed the title [DRAFT] [system] [ntp] add ntp data_stream [system] [ntp] add ntp data_stream Aug 19, 2025
@mykola-elastic mykola-elastic marked this pull request as ready for review August 19, 2025 12:50
@mykola-elastic mykola-elastic requested review from a team as code owners August 19, 2025 12:50
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Aug 19, 2025 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

tommyers-elastic
tommyers-elastic reviewed Aug 20, 2025
View reviewed changes
Copy link
Contributor

@tommyers-elastic tommyers-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to bump the kibana version to 9.2.0 here. (and we should probably wait to merge this until 9.2.0 is released).

do we want to include the clock offset on any existing dashboards?

@mykola-elastic
Copy link
Contributor Author

@tommyers-elastic what do you think about this? https://github.com/elastic/integrations/pull/14982/files#diff-89c55c1cf978566ceac8d2ee844e13faaf151d509741c574e6056ac11a5d700cR1-R3
Or should we spin up our own NTP server in docker for testing purposes?

@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Aug 21, 2025
@elasticmachine
Copy link

elasticmachine commented Aug 21, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @mykola-elastic

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
45.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommyers-elastic tommyers-elastic Awaiting requested review from tommyers-elastic

At least 1 approving review is required to merge this pull request.

Assignees

@mykola-elastic mykola-elastic

Labels
documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:system System Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mykola-elastic @elasticmachine @tommyers-elastic @andrewkroh