[websocket][proofpoint_on_demand] - Fixed system test failure issue #14981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e with streaming mockservers
ShourieG
added
bugfix
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
💚 Build Succeeded
cc @ShourieG |
|
efd6
approved these changes
Aug 20, 2025
| @@ -37,7 +37,6 @@ func handleWebSocket(w http.ResponseWriter, r *http.Request) { | |||
| log.Println(err) | |||
| return | |||
| } | |||
| defer conn.Close() | |||
There was a problem hiding this comment.
Yep. That's your problem right there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Proposed commit message
Note
Since this is only related to system tests, changelog and version increments have not been done.
A more detailed explanation of the issue can be found here.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots