[iptables] added optional space to process vyos logs #14948
+100
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robester0403
force-pushed
the
bug/iptables-vyos-logs-errors
branch
from
6ef3a27 to
648e7a4
Compare
robester0403
changed the title
robester0403
added
enhancement
🚀 Benchmarks reportTo see the full report comment with |
andrewkroh
reviewed
Aug 15, 2025
| @@ -57,7 +57,7 @@ processors: | |||
| - '%{IPTABLES_HOSTNAME}%{GREEDYDATA}\[%{UBIQUITI_LABEL}\]%{IPTABLES}%{SPACE}' | |||
| - '%{IPTABLES_ACTION}%{GREEDYDATA}%{IPTABLES}%{SPACE}' | |||
| - '%{IPTABLES_HOSTNAME}%{SPACE}%{UDM_LOGS}%{IPTABLES_IP_PAYLOAD}' | |||
| - '%{GREEDYDATA}\[%{UBIQUITI_LABEL}\]%{IPTABLES}%{SPACE}' | |||
| - '%{GREEDYDATA}\[%{UBIQUITI_LABEL}\](%{SPACE})?%{IPTABLES}%{SPACE}' | |||
There was a problem hiding this comment.
Why the trailing %{SPACE}? Is that necessary? The pattern is not anchored with $ so IIUC it will effectively ignore trailing space at the end. It's not covered by the test case either.
There was a problem hiding this comment.
Regarding the trailing space at the end of these patterns, I think it's not necessary. I tested it and it made no difference to the expected logs & current test cases. I will remove it from the patterns.
andrewkroh
reviewed
Aug 19, 2025
💚 Build Succeeded
History
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.- [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practicesHow to test this PR locally
Run and observe the new pipeline test to see expected corrected results.
Related Issues
Closes #10881