-
Notifications
You must be signed in to change notification settings - Fork 474
Replace Markdown Navigation with Links Panel #14938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🚀 Benchmarks reportTo see the full report comment with |
"attributes": { | ||
"color": "#4DD2CA", | ||
"description": "", | ||
"name": "Imperva" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there an Imperva tag is osquery?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the problem files, which came from trying to batch export all the dashboards. It should be fine now. Thanks!
@@ -0,0 +1,14 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these tag files need to be committed? I'm not actually sure how it works, but I thought that a kibana/tags.yml specified what tags to apply the dashboards, but we didn't need to commit the actual saved objects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While not completely sure, I deleted the tags and try to build the packages without the tags using elastic-package build
.
It fails for all three of the packages that had tags added (cisco_ise, fortinet_fortimail, and osquery).
💔 Build Failed
Failed CI StepsHistory
|
|
Proposed commit message
Checklist
changelog.yml
file.Author's Checklist
Built links panels for osquery and Cisco ISE to match the marked down before exactly in their kibana version.
Removed redundant information and links for imperva dashboard as discussed in #14812
Reviewed change logs and updated support for fortinet_fortimail to support kibana 8.11.0^ so we can add links panels.
Added links panels to fortinet_fortimail dashboard.
How to test this PR locally
Clone integrations repo.
Install elastic package locally.
Start elastic stack using elastic-package.
Install and test the packages locally with elastic-package
Go to dashboards and view the changes
Related issues
Closes #14812
Screenshots
Cisco ISE before:


Cisco ISE after
Osquery before:


Osquery after:


Fortinet Mail before:




Fortinet Mail after:




Imperva before. The integrations link is a relative link leading to the install integration page that can't be done in links panels. There is no navigation needed since it is only 1 dashboard page:


Imperva after: