Skip to content

Replace Markdown Navigation with Links Panel #14938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

robester0403
Copy link
Contributor

@robester0403 robester0403 commented Aug 14, 2025

Proposed commit message

Replaced markdown navigation in the cisco_ise, fortinet_fortimail, and osquery dashboards with more user-friendly link panels.

Updated the supported Kibana version for the fortinet_fortimail integration to 8.11.0^.

Removed the single redundant navigation link for the imperva integration dashboard.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

Built links panels for osquery and Cisco ISE to match the marked down before exactly in their kibana version.
Removed redundant information and links for imperva dashboard as discussed in #14812
Reviewed change logs and updated support for fortinet_fortimail to support kibana 8.11.0^ so we can add links panels.
Added links panels to fortinet_fortimail dashboard.

How to test this PR locally

Clone integrations repo.
Install elastic package locally.
Start elastic stack using elastic-package.
Install and test the packages locally with elastic-package
Go to dashboards and view the changes

Related issues

Closes #14812

Screenshots

Cisco ISE before:
Screenshot 2025-08-13 at 2 45 14 PM
Cisco ISE after
Screenshot 2025-08-13 at 2 51 15 PM

Osquery before:
Screenshot 2025-08-13 at 5 20 50 PM
Screenshot 2025-08-13 at 5 20 44 PM

Osquery after:
Screenshot 2025-08-13 at 5 24 45 PM
Screenshot 2025-08-13 at 5 22 47 PM

Fortinet Mail before:
Screenshot 2025-08-13 at 7 00 12 PM
Screenshot 2025-08-13 at 7 00 07 PM
Screenshot 2025-08-13 at 7 00 02 PM
Screenshot 2025-08-13 at 6 59 56 PM

Fortinet Mail after:
Screenshot 2025-08-15 at 9 59 29 AM
Screenshot 2025-08-14 at 11 52 16 AM
Screenshot 2025-08-14 at 11 50 24 AM
Screenshot 2025-08-14 at 11 47 28 AM

Imperva before. The integrations link is a relative link leading to the install integration page that can't be done in links panels. There is no navigation needed since it is only 1 dashboard page:
Screenshot 2025-08-13 at 3 17 57 PM
Imperva after:
Screenshot 2025-08-15 at 10 28 50 AM

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Aug 14, 2025

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@robester0403 robester0403 changed the title FIX: Replaced markdown links with links panels and removed redundant … Replaced markdown links with links panels and removed redundant … Aug 14, 2025
@andrewkroh andrewkroh added dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:imperva Imperva Integration:osquery Osquery Logs Integration:cisco_ise Cisco ISE Integration:fortinet_fortimail Fortinet FortiMail labels Aug 14, 2025
@robester0403 robester0403 added enhancement New feature or request Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience] labels Aug 15, 2025
@robester0403 robester0403 marked this pull request as ready for review August 15, 2025 14:50
@robester0403 robester0403 requested a review from a team as a code owner August 15, 2025 14:50
@robester0403 robester0403 changed the title Replaced markdown links with links panels and removed redundant … Replace Markdown Navigation with Links Panel Aug 15, 2025
"attributes": {
"color": "#4DD2CA",
"description": "",
"name": "Imperva"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there an Imperva tag is osquery?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the problem files, which came from trying to batch export all the dashboards. It should be fine now. Thanks!

@@ -0,0 +1,14 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these tag files need to be committed? I'm not actually sure how it works, but I thought that a kibana/tags.yml specified what tags to apply the dashboards, but we didn't need to commit the actual saved objects.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While not completely sure, I deleted the tags and try to build the packages without the tags using elastic-package build.

It fails for all three of the packages that had tags added (cisco_ise, fortinet_fortimail, and osquery).

@elasticmachine
Copy link

elasticmachine commented Aug 19, 2025

💔 Build Failed

Failed CI Steps

History

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:cisco_ise Cisco ISE Integration:fortinet_fortimail Fortinet FortiMail Integration:imperva Imperva Integration:osquery Osquery Logs Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Links Panel in dashboards for integration-experience integrations
3 participants