-
Notifications
You must be signed in to change notification settings - Fork 479
[O365] O365 UI layout improvements #14922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
|
show_user: false | ||
multi: false | ||
required: false | ||
- name: resource_redirect_headers_ban_list | ||
type: text | ||
title: Resource Redirect Headers Ban List | ||
description: When Redirect Forward Headers is set to true, all headers except the ones defined in this list will be forwarded. All headers are forwarded by default. | ||
description: If Redirect Forward Headers are set to true, all headers except the ones defined in this list will be forwarded. All headers are forwarded by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: If Redirect Forward Headers are set to true, all headers except the ones defined in this list will be forwarded. All headers are forwarded by default. | |
description: If "Resource Redirect Forward Headers" is set to true, all headers except the ones defined in this list will be forwarded. All headers are forwarded by default. |
The thing here is singular.
title: Oauth2 Token URL | ||
description: The Base URL endpoint that will be used to generate the tokens during the oauth2 flow. If not provided, above `Azure Tenant ID` will be used for oauth2 token generation. Default value - `https://login.microsoftonline.com` | ||
description: Base URL endpoint that will be used to generate the tokens during the oauth2 flow. If not provided, above `Azure Tenant ID` will be used for oauth2 token generation. Default value - `https://login.microsoftonline.com` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest "OAuth 2.0" for all cases where it's used since this is the official spelling.
title: "Collect Office 365 audit logs - Deprecated. Please disable this and use the CEL input instead." | ||
description: "Collect audit logs from Office 365 via the Management Activity API using Filebeat's O365Audit Input" | ||
title: "DEPRECATED - Collect audit logs" | ||
description: "Please deactivate this option and proceed using the one described above. Collects audit logs using the Management Activity API through a deprecated method." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: "Please deactivate this option and proceed using the one described above. Collects audit logs using the Management Activity API through a deprecated method." | |
description: "Please deactivate this input and instead use the one described above. This option collects audit logs using the Management Activity API through a deprecated method." |
description: "Collect audit logs using the Management Activity API" | ||
- type: o365audit | ||
title: "DEPRECATED - Collect audit logs" | ||
description: "Please deactivate this option and proceed using the one described above. Collect audit logs using the Management Activity API through a deprecated method." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: "Please deactivate this option and proceed using the one described above. Collect audit logs using the Management Activity API through a deprecated method." | |
description: "Please deactivate this input and instead use the one described above. This option collects audit logs using the Management Activity API through a deprecated method." |
@@ -1,4 +1,9 @@ | |||
# newer versions go on top | |||
- version: "2.22.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- version: "2.22.2" | |
- version: "2.23.0" |
since this is an enhancement.
@@ -1,6 +1,6 @@ | |||
name: o365 | |||
title: Microsoft Office 365 | |||
version: "2.21.1" | |||
version: "2.22.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version: "2.22.2" | |
version: "2.23.0" |
Proposed commit message
Update the O365 UI layout
New changes
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots