Skip to content

Conversation

narph
Copy link
Contributor

@narph narph commented Aug 13, 2025

Proposed commit message

Update the O365 UI layout

  • highlight deprecated data stream to deter users from selecting the option
  • Add consistency to the description labels

New changes

image image

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@narph narph requested a review from a team as a code owner August 13, 2025 15:23
@narph narph added Integration:o365 Microsoft Office 365 Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Aug 13, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

Copy link

show_user: false
multi: false
required: false
- name: resource_redirect_headers_ban_list
type: text
title: Resource Redirect Headers Ban List
description: When Redirect Forward Headers is set to true, all headers except the ones defined in this list will be forwarded. All headers are forwarded by default.
description: If Redirect Forward Headers are set to true, all headers except the ones defined in this list will be forwarded. All headers are forwarded by default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: If Redirect Forward Headers are set to true, all headers except the ones defined in this list will be forwarded. All headers are forwarded by default.
description: If "Resource Redirect Forward Headers" is set to true, all headers except the ones defined in this list will be forwarded. All headers are forwarded by default.

The thing here is singular.

Comment on lines 45 to +46
title: Oauth2 Token URL
description: The Base URL endpoint that will be used to generate the tokens during the oauth2 flow. If not provided, above `Azure Tenant ID` will be used for oauth2 token generation. Default value - `https://login.microsoftonline.com`
description: Base URL endpoint that will be used to generate the tokens during the oauth2 flow. If not provided, above `Azure Tenant ID` will be used for oauth2 token generation. Default value - `https://login.microsoftonline.com`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest "OAuth 2.0" for all cases where it's used since this is the official spelling.

title: "Collect Office 365 audit logs - Deprecated. Please disable this and use the CEL input instead."
description: "Collect audit logs from Office 365 via the Management Activity API using Filebeat's O365Audit Input"
title: "DEPRECATED - Collect audit logs"
description: "Please deactivate this option and proceed using the one described above. Collects audit logs using the Management Activity API through a deprecated method."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: "Please deactivate this option and proceed using the one described above. Collects audit logs using the Management Activity API through a deprecated method."
description: "Please deactivate this input and instead use the one described above. This option collects audit logs using the Management Activity API through a deprecated method."

description: "Collect audit logs using the Management Activity API"
- type: o365audit
title: "DEPRECATED - Collect audit logs"
description: "Please deactivate this option and proceed using the one described above. Collect audit logs using the Management Activity API through a deprecated method."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: "Please deactivate this option and proceed using the one described above. Collect audit logs using the Management Activity API through a deprecated method."
description: "Please deactivate this input and instead use the one described above. This option collects audit logs using the Management Activity API through a deprecated method."

@@ -1,4 +1,9 @@
# newer versions go on top
- version: "2.22.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- version: "2.22.2"
- version: "2.23.0"

since this is an enhancement.

@@ -1,6 +1,6 @@
name: o365
title: Microsoft Office 365
version: "2.21.1"
version: "2.22.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: "2.22.2"
version: "2.23.0"

@andrewkroh andrewkroh added the enhancement New feature or request label Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:o365 Microsoft Office 365 Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants