Adjust exception wrapping logic when converting to ES exceptions #132419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a broad brush to address #131548
It seemed weird to only address strange wrapping in only one place (the bitset logic). However, I admit, this is a pretty huge change.
There are many unknowns, so maybe this just isn't worth it. But it does seem weird that a Java Exception will have an ElasticsearchException as a cause and we would WANT to rather return the java exception rather than the inner ElasticsearchException...
//cc @javanna what do you think? Maybe we add a new "convertOrUnwrapToElastic" method and switch over good paths to that?