Skip to content

Conversation

@miguelgrinberg
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Nov 13, 2025

🔍 Preview links for changed docs

@miguelgrinberg miguelgrinberg force-pushed the docs-overview branch 8 times, most recently from 0949b58 to 221d83c Compare November 13, 2025 19:05
@miguelgrinberg
Copy link
Contributor Author

@marciw @pquentin Looking for early feedback on this reordering and expansion of the content in the overview page of the docs. I want to make it more clear that there are a number of somewhat independent things all included in this package, so I'm enumerating the four big components, each with links to its high level and reference docs. Let me know what you think, or if you have suggestions to improve this. Thanks!

@miguelgrinberg miguelgrinberg force-pushed the docs-overview branch 4 times, most recently from b8a5a3e to 41b8ef2 Compare November 14, 2025 10:44
@pquentin
Copy link
Member

This brings a lot of clarity, thank you!

I'd still like to see a code example above the fold, maybe not as a REPL session. I've seen user interviews where users in a hurry don't read anything, but copy/paste the first text snippet they see and try to adapt it to their needs.

@miguelgrinberg
Copy link
Contributor Author

miguelgrinberg commented Nov 14, 2025

@pquentin I agree with having a short example above this overview. But the example that we currently feature is not great, first because it shows a console use, which is not what most people would want, and second because it focuses on this obscure fact about serialisation of datetime objects, which has no place at this high-level. I have now replaced the example with a regular search call generated by the request converter, and moved it to the top of the page.

EDIT: now made this example tabbed, with sync and async versions!

@miguelgrinberg miguelgrinberg marked this pull request as ready for review November 14, 2025 16:17
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. Sorry for the wait.

@miguelgrinberg miguelgrinberg merged commit 214a627 into elastic:main Nov 20, 2025
15 checks passed
@miguelgrinberg miguelgrinberg deleted the docs-overview branch November 20, 2025 09:45
@github-actions
Copy link

The backport to 9.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.2 9.2
# Navigate to the new working tree
cd .worktrees/backport-9.2
# Create a new branch
git switch --create backport-3158-to-9.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 214a6279fb24688269c97249d5a95fd395814e6a
# Push it to GitHub
git push --set-upstream origin backport-3158-to-9.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.2

Then, create a pull request where the base branch is 9.2 and the compare/head branch is backport-3158-to-9.2.

github-actions bot pushed a commit that referenced this pull request Nov 20, 2025
miguelgrinberg added a commit that referenced this pull request Nov 20, 2025
(cherry picked from commit 214a627)

Co-authored-by: Miguel Grinberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants