Fix missing assignment #3151
Merged
Fix missing assignment #3151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
Contributor
|
@celeste0-0sec Thanks for the bug fix! Can you please sign the CLA so that I can apply this change? |
Contributor
|
@celeste0-0sec I'm unable to merge this until you sign the CLA. If you already signed, the issue is that you signed with an email that is different from the one you are using in this PR. Please sign again, making sure you use the same email. Thanks! |
Member
|
I triggered the CLA again and can confirm that it was signed, thank you! |
Member
|
buildkite test this please |
Member
|
buildkite test this please |
miguelgrinberg
approved these changes
Nov 20, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit fa8fe72)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit fa8fe72)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit fa8fe72)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit fa8fe72)
miguelgrinberg
pushed a commit
that referenced
this pull request
Nov 20, 2025
(cherry picked from commit fa8fe72) Co-authored-by: celeste0-0sec <[email protected]> Co-authored-by: Quentin Pradet <[email protected]>
miguelgrinberg
pushed a commit
that referenced
this pull request
Nov 20, 2025
(cherry picked from commit fa8fe72) Co-authored-by: celeste0-0sec <[email protected]> Co-authored-by: Quentin Pradet <[email protected]>
miguelgrinberg
pushed a commit
that referenced
this pull request
Nov 20, 2025
(cherry picked from commit fa8fe72) Co-authored-by: celeste0-0sec <[email protected]> Co-authored-by: Quentin Pradet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change corrects identifier escaping in
elasticsearch/esql/esql.pyby properly assigning the result ofstr.replace()back to the local variable before wrapping the identifier in backticks. Previously thereplace()call produced a new string that was discarded; this leaves inner backticks unescaped. The patch ensures internal backticks are doubled so the rendered ES|QL identifier is quoted correctly.