edot: reduces overrides in docker and k8s example config #455
+2
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the override for flush bytes as interestingly the apm-server one applied to compressed data
This also removes the apm-server anecdote replacing it with a valid purpose here.
Example apps are not likely to produce 5000000 bytes of data. This means you won't see a trace in kibana for 30s after whatever the interval is on the app exporter side (usually overridden to be a few seconds). Unless you reduce the collector-side interval, demos done by solutions architects, devrels and engineers will suffer. Also, any arbitrary people trying this will likely wonder why nothing is in kibana. Hence, regardless of this being the apm-server default, it makes sense to reduce this to 1s.