Use locally hosted services for tests #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelgrinberg
force-pushed
the
use-local-httpbin
branch
from
96083ac to
5e7866c
Compare
miguelgrinberg
force-pushed
the
use-local-httpbin
branch
9 times, most recently
from
00b3559 to
79ae29a
Compare
miguelgrinberg
force-pushed
the
use-local-httpbin
branch
from
79ae29a to
8254da5
Compare
miguelgrinberg
changed the title
miguelgrinberg
changed the title
miguelgrinberg
force-pushed
the
use-local-httpbin
branch
from
0beea46 to
8fad2d9
Compare
miguelgrinberg
force-pushed
the
use-local-httpbin
branch
from
8fad2d9 to
4bf82b6
Compare
pquentin
approved these changes
Jul 10, 2025
Member
pquentin
left a comment
pquentin
left a comment
There was a problem hiding this comment.
Thanks! This is a great step forward - there are possible improvements, but they can be treated as follow ups.
|
|
||
| @pytest.mark.asyncio | ||
| async def test_async_transport_httpbin(httpbin_node_config): | ||
| async def test_async_transport_httpbin(httpbin_node_config, httpbin): |
Member
There was a problem hiding this comment.
nit: as a follow-up, we could add an url property to NodeConfig, which would avoid accepting both httpbin and httpbin_node_config. (It took me a while to understand.)
Comment on lines
92
to
93
| # This is the root CA for httpbin.org with a leading comma to denote more than one cert was listed. | ||
| assert ', "8ecde6884f3d87b1125ba31ac3fcb13d7016de7f57cc904fe1cb97c6ae98196e"' in err | ||
| assert ', "cbb522d7b7f127ad6a0113865bdf1cd4102e7d0759af635a7cf4720dc963c53b"' in err |
Member
There was a problem hiding this comment.
The certificate is currently generated by trustme: kevin1024/pytest-httpbin#90. Since it generates its own CA, this is going to be less stable than before. Additionally, the comment is out of date.
Contributor
Author
There was a problem hiding this comment.
This is the root CA for www.elastic.co, this is the one test that does not use the local httpbin.
Member
There was a problem hiding this comment.
Oh, sorry. This should be pretty stable. Can we update the comment above then?
github-actions bot
pushed a commit
that referenced
this pull request
Jul 10, 2025
* Use a locally hosted httpbin for tests * use a www.elastic.co instead of httpbin.org for SSL tests * use pytest-httpbin instead of a local service * use pytest-httpbin also for SSL tests * fix inaccurate comment (cherry picked from commit 23d0f56)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 10, 2025
* Use a locally hosted httpbin for tests * use a www.elastic.co instead of httpbin.org for SSL tests * use pytest-httpbin instead of a local service * use pytest-httpbin also for SSL tests * fix inaccurate comment (cherry picked from commit 23d0f56)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 10, 2025
* Use a locally hosted httpbin for tests * use a www.elastic.co instead of httpbin.org for SSL tests * use pytest-httpbin instead of a local service * use pytest-httpbin also for SSL tests * fix inaccurate comment (cherry picked from commit 23d0f56)
This was referenced Jul 10, 2025
miguelgrinberg
added a commit
that referenced
this pull request
Jul 10, 2025
* Use a locally hosted httpbin for tests * use a www.elastic.co instead of httpbin.org for SSL tests * use pytest-httpbin instead of a local service * use pytest-httpbin also for SSL tests * fix inaccurate comment (cherry picked from commit 23d0f56) Co-authored-by: Miguel Grinberg <[email protected]>
miguelgrinberg
added a commit
that referenced
this pull request
Jul 10, 2025
* Use a locally hosted httpbin for tests * use a www.elastic.co instead of httpbin.org for SSL tests * use pytest-httpbin instead of a local service * use pytest-httpbin also for SSL tests * fix inaccurate comment (cherry picked from commit 23d0f56) Co-authored-by: Miguel Grinberg <[email protected]>
miguelgrinberg
added a commit
that referenced
this pull request
Jul 10, 2025
* Use a locally hosted httpbin for tests * use a www.elastic.co instead of httpbin.org for SSL tests * use pytest-httpbin instead of a local service * use pytest-httpbin also for SSL tests * fix inaccurate comment (cherry picked from commit 23d0f56) Co-authored-by: Miguel Grinberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace calls to httpbin.org with a locally hosted hhtpbin server to avoid the high number of 502s in test runs. The pytest-httpbin plugin is used for this. There is a test that requires a certificate chain. For that I'm using www.elastic.co instead of the flaky httpbin.org, which hopefully is going to be more reliable. I also haven't touched the tests that send requests to badssl.com, since those appear to be stable in CI.