Add basedir config to reuse cache from different directories #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature is equivalent to `CCACHE_BASEDIR` and enables cache reuse across directories. This is needed because some absolute paths can end up in the preprocessed output via `__FILE__` macros or other debugging mechanisms. This causes cache misses even though the code is otherwise identical. When `CLANG_TIDY_CACHE_BASEDIR`/`base_dir` is set, we replace absolute paths that match that base prefix with relative paths in the preprocessed output. Additionally, we need to pass the `-P` flag to the preprocessor to avoid linemarker comments that indicate which bit of the output came from which header path.
aminya
approved these changes
Jan 1, 2022
aminya
suggested changes
Feb 9, 2022
| if err != nil { | ||
| return nil, err | ||
| } | ||
| defer f.Close() |
There was a problem hiding this comment.
This causes a bug that is fixed in #17. The file is not closed before calling os.Remove at line 110, which results in an error.
mathstuf
pushed a commit
to mathstuf/clang-tidy-cache
that referenced
this pull request
Jan 18, 2023
…exports runClangTidyCommand: cache the stdout if no export-file is given
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is equivalent to
CCACHE_BASEDIRand enables cache reuse across directories. This is needed because some absolute paths can end up in the preprocessed output via__FILE__macros or other debugging mechanisms. This causes cache misses even though the code is otherwise identical.When
CLANG_TIDY_CACHE_BASEDIR/base_diris set, we replace absolute paths that match that base prefix with relative paths in the preprocessed output.Additionally, we need to pass the
-Pflag to the preprocessor to avoid linemarker comments that indicate which bit of the output came from which header path.