Skip to content

add Cost Rate (Fixes #372) #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025
Merged

add Cost Rate (Fixes #372) #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a80822
Add CostRate to TimeActivity
laf-rge Mar 16, 2025
7bc2973
add integration test
laf-rge Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions quickbooks/objects/timeactivity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ def __init__(self):
self.StartTime = None
self.EndTime = None
self.Description = None
self.CostRate = None

self.VendorRef = None
self.CustomerRef = None
Expand Down
4 changes: 4 additions & 0 deletions tests/integration/test_timeactivity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ def test_create(self):
time_activity.Description = "Test description"
time_activity.StartTime = qb_datetime_utc_offset_format(datetime(2016, 7, 22, 10, 0), '-07:00')
time_activity.EndTime = qb_datetime_utc_offset_format(datetime(2016, 7, 22, 11, 0), '-07:00')
time_activity.CostRate = 50.0
time_activity.save(qb=self.qb_client)

query_time_activity = TimeActivity.get(time_activity.Id, qb=self.qb_client)
Expand All @@ -30,6 +31,7 @@ def test_create(self):
self.assertEqual(query_time_activity.NameOf, "Employee")
self.assertEqual(query_time_activity.Description, "Test description")
self.assertEqual(query_time_activity.EmployeeRef.value, employee.Id)
self.assertEqual(query_time_activity.CostRate, 50.0)

# Quickbooks has issues with returning the correct StartTime and EndTime
#self.assertEqual(query_time_activity.StartTime, '2016-07-22T10:00:00-07:00')
Expand All @@ -38,8 +40,10 @@ def test_create(self):
def test_update(self):
time_activity = TimeActivity.all(max_results=1, qb=self.qb_client)[0]
time_activity.Description = "Updated test description"
time_activity.CostRate = 75.0
time_activity.save(qb=self.qb_client)

query_time_activity = TimeActivity.get(time_activity.Id, qb=self.qb_client)

self.assertEqual(query_time_activity.Description, "Updated test description")
self.assertEqual(query_time_activity.CostRate, 75.0)
4 changes: 2 additions & 2 deletions tests/unit/objects/test_timeactivity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ def test_unicode(self):
time_activity = TimeActivity()

time_activity.NameOf = "test"
time_activity.TimeZone = "CST"
time_activity.BillableStatus = "test"
time_activity.Taxable = False
time_activity.HourlyRate = 0
Expand All @@ -18,9 +17,9 @@ def test_unicode(self):
time_activity.BreakHours = 1
time_activity.BreakMinutes = 60
time_activity.Description = "test"
time_activity.CostRate = 50.0

self.assertEqual(str(time_activity), "test")
self.assertEqual(time_activity.TimeZone, "CST")
self.assertEqual(time_activity.BillableStatus, "test")
self.assertEqual(time_activity.Taxable, False)
self.assertEqual(time_activity.HourlyRate, 0)
Expand All @@ -29,6 +28,7 @@ def test_unicode(self):
self.assertEqual(time_activity.BreakHours, 1)
self.assertEqual(time_activity.BreakMinutes, 60)
self.assertEqual(time_activity.Description, "test")
self.assertEqual(time_activity.CostRate, 50.0)

def test_valid_object_name(self):
obj = TimeActivity()
Expand Down