Skip to content

Conversation

@sub77
Copy link

@sub77 sub77 commented Mar 29, 2017

No description provided.

@M1cha
Copy link
Member

M1cha commented Mar 29, 2017

this commit doesn't make any sense and the arguments are wrong.
Can you explain what you tried to do here?

@sub77
Copy link
Author

sub77 commented Mar 30, 2017

i tried to get my falcon working again since the mmap api changes you comitted in january. without this commit my two msm8226 devices (moto g 2013 and galaxy tab4) stopped booting uefi completly.

@M1cha
Copy link
Member

M1cha commented Mar 30, 2017

this may be true but this commit only works by accident. I mean look at it. you're completely ignoring the argument order and you only don't see errors because all arguments are of type int.

@sub77
Copy link
Author

sub77 commented Mar 30, 2017

for sure, iam a compiler only, no dev. just had a look at the mmap parameters before the api change and now it is working again.

@z3ntu
Copy link

z3ntu commented Apr 5, 2017

this commit doesn't make any sense and the arguments are wrong.

Got uefi booting with #19

lol

@sub77
Copy link
Author

sub77 commented Apr 5, 2017

#21

@sub77 sub77 closed this Apr 6, 2017
@sub77
Copy link
Author

sub77 commented Apr 6, 2017

@joe2k01
Copy link

joe2k01 commented Apr 6, 2017

@z3ntu He gave me the file he used and I referenced the wrong commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants