Adds various features and new behavior #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes introduced in this rollup include: * Discriminating on Python major version in load_manifest * The "universal newline" flag has been assumed by default in all versions of Python 3, was deprecated in 3.3, and no longer functions in 3.11. This code includes a branch on detected Python major version to perform the correct open() command. * Adds a -skippatches flag to download and verify commands (Thanks to Xeniac-at) * There are a lot of patches available, and people may or may not want to download them all for space concerns. This feature allows the user to skip them. Crucially, the current implementation leaves the patch information in the local manifest, allowing users to download patches on an as-desired basis. This behavior is also added to the verify command, reducing the number of "missing file" entries. * Updates functionality for the verify command * By default, this script counts up the number of items that fail to verify, but don't list them. That isn't as helpful as it could be, so a new behavior additionally collects the directory path of the failed item(s) and lists them at the end of the operation. * Various grammatical fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced in this rollup include:
Discriminating on Python major version in load_manifest
Adds a -skippatches flag to download and verify commands (Thanks to Xeniac-at)
Updates functionality for the verify command
Various grammatical fixes