Feature/migrate session from rc #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…logging library; remove Ed-Fi 2 functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Migrate Session from RC
Description & motivation
The RC/0.3.0 branch contains a number of updates to this package. Some are quality-of-life and not important to release on a strict timeline, and others are serious code refactors that add flexibility to the project as a whole.
This PR isolates one particular refactor: moving
EdFiSessioninto its own class that handles all authentication and retry logic. This PR was requested by the Cloud Engineering team in preparation for a near-future update.At a high level, this PR makes the following changes:
verbose_logprint statements in favor of using the logging library.As a side-effect of these changes, compatibility with Ed-Fi 2 has been removed in this update.
PR Merge Priority:
Tests and QC done:
This has been tested interactively and by Mark in a dev process in South Carolina. One thing to still verify is that retries work identically as before on long-running GETs.