feat: omegaconf based configs #223
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
floriankrb
pushed a commit
to ecmwf/anemoi-datasets
that referenced
this pull request
Oct 6, 2025
## Description Fix as a pre-requisite to ecmwf/anemoi-utils#223 because the class hiearchy will change and the removed line created an exception. ## What problem does this change solve? <!-- Describe if it's a bugfix, new feature, doc update, or breaking change --> ## What issue or task does this change relate to? <!-- link to Issue Number --> ## Additional notes ## <!-- Include any additional information, caveats, or considerations that the reviewer should be aware of. --> ***As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/*** By opening this pull request, I affirm that all authors agree to the [Contributor License Agreement.](https://github.com/ecmwf/codex/blob/main/Legal/contributor_license_agreement.md)
gmertes
reviewed
Oct 28, 2025
Member
gmertes
left a comment
gmertes
left a comment
There was a problem hiding this comment.
The PR seems to break anemoi-datasets, something to do with the building of the loaders config? Is it because of the changes to the DotDict (which datasets.create.Config inherits from) ?
Member
|
My opinion atm is that as Omegaconf is hardly supported, we should look at reimplementing it within utils to control the code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This prepare the ground for supporting OmegaConf substitutions in all YAML files (especially datasets and inference). The
DotDictis now a subclass of the OmegaConf object, so we keep backward compatibility with existing code.Note that the previous
config.pyhas been split betweenconfig.pyandsettings.py, the former handling general config files, the latter handling user settings. Backward compatibility will be supported for a while, with deprecation warnings.What problem does this change solve?
What issue or task does this change relate to?
Additional notes
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.