Enable force platform minnowboard turbot #827
Open
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tripzero
force-pushed
the
fix_minnow_turbot
branch
from
aa06bff to
f55646c
Compare
tripzero
force-pushed
the
fix_minnow_turbot
branch
from
f55646c to
93f6092
Compare
|
Uhm I can see why you do this but can we avoid adding something in types.h?
Also you need to sign off your patches.
…On 27 Sep 2017 18:19, "Kevron Rees" ***@***.***> wrote:
Reopened #827 <#827>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#827 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAfZZpuDTkqduiBQcrGpSumnddKclAQTks5smnWDgaJpZM4PmAF_>
.
|
Compile error would result if force minnowboard max. This is because mraa_intel_minnowboard_byt_compatible signature requires bool option for max or turbot board variations. This patch allows user to force platform for either max or turbot without compile error. Signed-off-by: Kevron Rees <[email protected]>
tripzero
force-pushed
the
fix_minnow_turbot
branch
from
93f6092 to
7d47370
Compare
|
We need some way of specifying the subtype for turbot. The only other way I can think of is to create another CMAKE option for subtype. I'm running into this because I'm trying to use mraa in a container. I can get around it by forwarding /sys/devices/virtual/dmi/id/board_name into the container and letting autodetect work. |
|
Why do we need a way of specifying the subtype? Since it's basically the same platform this seems odd... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compile error would result if force minnowboard max. This is
because mraa_intel_minnowboard_byt_compatible signature requires
bool option for max or turbot board variations. This patch allows
user to force platform for either max or turbot without compile
error.