Update preference doc #852
Merged
+423
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasHelming
temporarily deployed
to
pull-request-preview
GitHub Actions
Inactive
|
tsmaeder
reviewed
Oct 2, 2025
| const preferences = ctx.container.get<PreferenceService>(PreferenceService); | ||
| const contribution = ctx.container.get<PreferenceContribution>(MyExtensionPreferenceContribution); | ||
| return createMyExtensionPreferences(preferences, contribution.schema); | ||
| }).inSingletonScope(); |
There was a problem hiding this comment.
Shouldn't the preferences be integrated in the preference layout somehow? See preference-layout.ts?
There was a problem hiding this comment.
I don't get this, sorry :-)
|
@tsmaeder Ping! |
|
@tsmaeder I am merging this now, as the current version is outdated and worse compared to the PR. Please provide additional feedback as issue or PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.