Skip to content

score_docs_as_code: Update to 2.0.2 #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

score_docs_as_code: Update to 2.0.2 #158

wants to merge 1 commit into from

Conversation

@umaucher
Copy link
Contributor

@umaucher umaucher commented Oct 30, 2025 •
edited
Loading

  • score_docs_as_code 2.0.1 -> 2.0.2
  • rules_python needs to stay to 1.4.1 (but dev_dependency)

@github-actions
Copy link

github-actions bot commented Oct 30, 2025 •
edited
Loading

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output 
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: e1e1294c-8c7f-4b24-973f-84ef3199ff92
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rust_qnx8_toolchain+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-oEubHgeZDdT0svMmBKJx7c3/2TdSI/vfwRUyDn+TPGA="
DEBUG: Repository rust_qnx8_toolchain+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_rust', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'platforms', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
Analyzing: target //:license-check (5 packages loaded, 0 targets configured)
Analyzing: target //:license-check (5 packages loaded, 0 targets configured)

Analyzing: target //:license-check (84 packages loaded, 9 targets configured)

Analyzing: target //:license-check (154 packages loaded, 1372 targets configured)

Analyzing: target //:license-check (162 packages loaded, 6985 targets configured)

INFO: Analyzed target //:license-check (165 packages loaded, 9001 targets configured).
[3 / 13] Creating runfiles tree bazel-out/k8-fastbuild/bin/license.check.license_check.runfiles; 0s local
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 65 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 21.399s, Critical Path: 0.52s
INFO: 14 processes: 5 disk cache hit, 9 internal.
INFO: Build completed successfully, 14 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

The created documentation from the pull request is available at: docu-html

@umaucher umaucher marked this pull request as ready for review October 30, 2025 07:11
umaucher
umaucher commented Oct 31, 2025
View reviewed changes
MODULE.bazel Outdated
remote = "https://github.com/qorix-group/testing_tools.git",
)

# ToDo: needed to get //:docs running until > 0.3.0 is officially released
Copy link
Contributor Author

@umaucher umaucher Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be addressed with eclipse-score/score#1925

arkjedrz
arkjedrz suggested changes Oct 31, 2025
View reviewed changes
MODULE.bazel
## Toolchains (dependencies and config)
# python
bazel_dep(name = "rules_python", version = "1.4.1")
# ToDo: score_docs_as_code broken with any later version >1.4.1 (e.g. 1.6.3)
Copy link
Contributor

@arkjedrz arkjedrz Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to others, create a ticket and provide a link.

Copy link
Contributor Author

@umaucher umaucher Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see eclipse-score/docs-as-code#295

vinodreddy-g
vinodreddy-g reviewed Nov 3, 2025
View reviewed changes
MODULE.bazel Outdated
module_name = "score_docs_as_code",
commit = "13ba715a95cfe85158b60d7f4748ba8e28895d8c",
remote = "https://github.com/eclipse-score/docs-as-code.git",
module_name = "score_platform",
Copy link
Contributor

@vinodreddy-g vinodreddy-g Nov 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need dep to score_platform and score_process , are we using needs_json ?

Copy link
Contributor Author

@umaucher umaucher Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is referenced in https://github.com/eclipse-score/persistency/blob/main/BUILD#L21 and I think needed for the links in https://github.com/eclipse-score/persistency/blob/main/docs/index.rst but haven't explicitly verified tbh

Copy link
Contributor Author

@umaucher umaucher Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so I checked the dependency is needed otherwise this triggers errors like:

/home/runner/work/persistency/persistency/docs/index.rst:117: WARNING: linked need S-CORE_feat_req__persistency__cpp_rust_interop not found [needs.link_ref]

@pawelrutkaq
Copy link
Contributor

pawelrutkaq commented Nov 3, 2025

look here https://github.com/eclipse-score/tooling?tab=readme-ov-file#upgrading-from-separate-modules

@umaucher
Copy link
Contributor Author

umaucher commented Nov 3, 2025

look here https://github.com/eclipse-score/tooling?tab=readme-ov-file#upgrading-from-separate-modules

this we did in a separate PR --> #155

@vinodreddy-g
Copy link
Contributor

vinodreddy-g commented Nov 7, 2025

@umaucher could you resolve the conflict and then we can merge it?

@umaucher umaucher force-pushed the um_sdac_update branch 2 times, most recently from f6bf5d3 to c755d5e Compare November 10, 2025 08:40
@umaucher umaucher requested a review from arkjedrz November 10, 2025 09:06
@umaucher umaucher mentioned this pull request Nov 10, 2025
Open
@umaucher
score_docs_as_code: Update to 2.0.2
1d741bd 
- score_docs_as_code 2.0.1 -> 2.0.2
- rules_python needs to stay to 1.4.1 (but dev_dependency)
@umaucher umaucher changed the title score_docs_as_code: Update to 1.4.0 score_docs_as_code: Update to 2.0.2 Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vinodreddy-g vinodreddy-g vinodreddy-g left review comments

@arkjedrz arkjedrz Awaiting requested review from arkjedrz

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@umaucher @pawelrutkaq @vinodreddy-g @arkjedrz