Fixes to enable daily calibration frequency #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corentincarton
commented
Nov 2, 2021
| elif cfg.calibration_freq == r'daily': | ||
| index = pd.to_datetime(pd.date_range(start, end, freq='24H'), format='%d/%m/%Y %H:%M', errors='raise') | ||
| else: | ||
| raise Exception('Calibration freq {} not supported'.format(cfg.calibration_freq)) |
There was a problem hiding this comment.
@doc78 , I'm wondering if it wouldn't be cleaner to put the if statement for the calibration_freq in the config and then use the value to derive directly the step when constructing the time series:
it would give something like:
index = pd.to_datetime(pd.date_range(start, end, freq='{}H'.format(cfg.freq_hours)), format='%d/%m/%Y %H:%M', errors='raise')
There was a problem hiding this comment.
We could even put a value in minutes to be more future proof.
corentincarton
commented
Nov 2, 2021
| simulated_streamflow.index = [(datetime.strptime(start, "%d/%m/%Y %H:%M") + timedelta(hours=24*i)).strftime('%d/%m/%Y %H:%M') for i in range(len(simulated_streamflow.index))] | ||
| else: | ||
| raise Exception('Calibration freq {} not supported'.format(self.cfg.calibration_freq)) | ||
|
|
There was a problem hiding this comment.
Same here, it would give:
simulated_streamflow.index = [(datetime.strptime(start, "%d/%m/%Y %H:%M") + timedelta(hours=cfg.freq_hours*i)).strftime('%d/%m/%Y %H:%M') for i in range(len(simulated_streamflow.index))]
corentincarton
pushed a commit
that referenced
this pull request
Jul 5, 2022
Merge in CEFL/lisflood-calibration from damienWorking to develop * commit '61b118e42b9c390bae325a7fd7c146f2021c142e': modified aux scripts (all but CAL_7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.