Skip to content

introduce XORG_*_URLS and GNU_FTP_URLS template constants #4935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

jfgrimm
Copy link
Member

@jfgrimm jfgrimm commented Jun 24, 2025

No description provided.

@jfgrimm jfgrimm added this to the 5.x milestone Jun 24, 2025
@jfgrimm jfgrimm requested a review from branfosj June 24, 2025 11:42
@boegel
Copy link
Member

boegel commented Jun 24, 2025

@jfgrimm Is there a public statement somewhere that announces this?

If so, we should mention it in the PR description, maybe also in the commit message?

@boegel boegel modified the milestones: 5.x, next release (5.1.1?) Jun 24, 2025
@jfgrimm
Copy link
Member Author

jfgrimm commented Jun 24, 2025

@boegel I haven't been able to find one, still looking

@boegel boegel changed the title update XORG_*_SOURCE constants to use new URL update XORG_*_SOURCE constants to use new URL (x.org/archive rather than xorg.freedesktop.org/archive) Jun 24, 2025
@boegel
Copy link
Member

boegel commented Jun 24, 2025

Recent release announcements still point to xorg.freedesktop.org/archive, see for example https://lists.x.org/archives/xorg/2025-June/062056.html

@boegel
Copy link
Member

boegel commented Jun 24, 2025

@jfgrimm As discussed in Slack, a better alternative is probably to introduce new XORG_* constants that provide tuples of source URLs, so both will be tried?

@PhoenixEmik
Copy link

Source: https://www.x.org/wiki/Releases/Download/
@boegel The page indicates that freedesktop.org and x.org are both primary download sites for X, and there are multiple mirrors as well. I support introducing new XORG_* constant tuples containing primary download sites and mirrors to improve this.

@jfgrimm jfgrimm force-pushed the update-xorg-urls branch from 31f8299 to 918d92c Compare June 25, 2025 10:09
@jfgrimm jfgrimm changed the title update XORG_*_SOURCE constants to use new URL (x.org/archive rather than xorg.freedesktop.org/archive) introduce XORG_*_URLS and GNU_FTP_URLS template constants Jun 25, 2025
@jfgrimm jfgrimm modified the milestones: next release (5.1.1?), 5.x Jun 25, 2025
@jfgrimm jfgrimm force-pushed the update-xorg-urls branch from 6c38727 to 3f39f32 Compare June 25, 2025 11:28
@boegel
Copy link
Member

boegel commented Jun 26, 2025

@jfgrimm Can you look into failing CI?

@boegel boegel modified the milestones: 5.x, next release (5.1.1?) Jun 26, 2025
@jfgrimm
Copy link
Member Author

jfgrimm commented Jun 30, 2025

@boegel will take a look, I think it's failing on the from-commit test

@jfgrimm
Copy link
Member Author

jfgrimm commented Jul 3, 2025

@boegel not sure how to best tackle the failing from_commit tests hitting the deprecation warning

@boegel
Copy link
Member

boegel commented Jul 30, 2025

@boegel not sure how to best tackle the failing from_commit tests hitting the deprecation warning

@jfgrimm We'll need to update those to using a different/newer commit.

If we already open an easyconfig PR for easyconfigs using the SYSTEM toolchain (like ncurses-6.2.eb) to stop using the deprecated constants like GNU_SOURCE, we can already bump the commit used in test_from_commit even though the easyconfig PR isn't merged yet (it can only be merged after this PR got merged)...

@jfgrimm
Copy link
Member Author

jfgrimm commented Jul 30, 2025

I've currently got easybuilders/easybuild-easyconfigs#23299 open, which updates the use in all easyconfigs
Want me to split ncurses out into a separate PR, or is one large PR OK for the test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants