Skip to content

Conversation

glegendr
Copy link

@glegendr glegendr commented Aug 8, 2025

add list_parts function as described here
https://docs.aws.amazon.com/AmazonS3/latest/API/API_ListParts.html


This change is Reviewable

@durch
Copy link
Owner

durch commented Sep 16, 2025

@glegendr thank you for the contribution, I wonder if you could add a test, along the lines of those for methods, maybe reuse one of the multipart upload test, or just add an assertion in there

@durch durch requested a review from Copilot September 16, 2025 18:02
@durch durch changed the base branch from master to 0.37.0-alpha.1 September 16, 2025 18:02
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a list_parts function to the S3 client that implements the AWS S3 ListParts API for retrieving information about parts uploaded for a specific multipart upload.

  • Added ListPartsResult struct to deserialize S3 ListParts API responses
  • Added ListParts command variant with support for pagination parameters
  • Implemented both async and sync versions of the list_parts method

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
s3/src/serde_types.rs Added ListPartsResult struct and made Part struct deserializable
s3/src/command.rs Added ListParts command variant and integrated it into command handling
s3/src/request/request_trait.rs Added URL parameter handling for ListParts command
s3/src/bucket.rs Implemented list_parts method with async and sync variants

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@durch durch deleted the branch durch:0.37.0-alpha.1 September 16, 2025 21:55
@durch durch closed this Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants