Improve error handlers #760
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Y--
force-pushed
the
yl/improve-func-guards
branch
from
ac7be56 to
e51c83d
Compare
JelteF
reviewed
May 6, 2025
There was a problem hiding this comment.
Really cool! I think we'll want something like this for sure, but I'm going to punt on reviewing this in detail until after the 1.0 release. It looks scary enough and touches important enough code that I'd like to have this bake for a while on the main branch.
include/pgduckdb/pgduckdb_utils.hpp
Outdated
| throw duckdb::Exception(duckdb::ExceptionType::EXECUTOR, "Failed to extract Postgres error message"); | ||
| pd_log(WARNING, "(PGGuard/%s) Exception in %s:%d: could not extract ErrorData.", func_name, file_name, | ||
| line); | ||
| throw Exception(); // This is a pretty bad situation - we failed to extract the error message. |
There was a problem hiding this comment.
Why did you remove the error message from this exception?
There was a problem hiding this comment.
Just because it was a canned message and I wanted to throw a pgduckdb::Exception in both case, but we also could keep the original one.
Y--
force-pushed
the
yl/improve-func-guards
branch
2 times, most recently
from
97f9b4f to
e4bb734
Compare
Y--
force-pushed
the
yl/improve-func-guards
branch
4 times, most recently
from
287f756 to
e580e9c
Compare
Y--
force-pushed
the
yl/improve-func-guards
branch
from
e580e9c to
edbaf71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever a Postgres error is thrown and capture by our C++ code (or in DuckDB) we were re-throwing a generic
duckdb::EXECUTORfor no specific reason.Instead this PR throws a custom exception that captures the Postgres
ErrorDataobject to be handled by the corresponding C++ exception handler, which will eventually convert it back to a Postgres exception.The resulting errors are much nicer as a result and preserve more information.
We could even add even more logging/tracing details such as which function was wrapped etc. (I was not sure where to put it exactly:
context,detail, orNOTICElog, but trivial to improve).The main drawback of this approach is that we have to serialize the
ErrorDatapointer to make sure that even if DuckDB capture the exception and re-throw with another type we do not loose the Postgres information, but there is no foul-proof way of making sure that the pointer will be valid in the C++ handler.