Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/functions/ducklake_add_data_files.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ static unique_ptr<FunctionData> DuckLakeAddDataFilesBind(ClientContext &context,

names.emplace_back("filename");
return_types.emplace_back(LogicalType::VARCHAR);
return result;
return std::move(result);
}

struct DuckLakeAddDataFilesState : public GlobalTableFunctionState {
Expand Down
1 change: 1 addition & 0 deletions src/functions/ducklake_list_files.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#include "functions/ducklake_table_functions.hpp"
#include "storage/ducklake_table_entry.hpp"
#include "storage/ducklake_transaction.hpp"
#include "common/ducklake_util.hpp"
#include "storage/ducklake_transaction_changes.hpp"
Expand Down
11 changes: 8 additions & 3 deletions src/include/storage/ducklake_transaction.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ class DuckLakeTransaction : public Transaction, public enable_shared_from_this<D
~DuckLakeTransaction() override;

public:
void Start();
void Commit();
void Rollback();
virtual void Start();
virtual void Commit();
virtual void Rollback();

DuckLakeCatalog &GetCatalog() {
return ducklake_catalog;
Expand Down Expand Up @@ -125,6 +125,11 @@ class DuckLakeTransaction : public Transaction, public enable_shared_from_this<D
//! Otherwise, it is an id that is incremented whenever the schema changes (not stored between restarts)
idx_t GetCatalogVersion();

protected:
void SetMetadataManager(unique_ptr<DuckLakeMetadataManager> metadata_manager) {
this->metadata_manager = std::move(metadata_manager);
}

private:
void CleanupFiles();
void FlushChanges();
Expand Down
2 changes: 1 addition & 1 deletion src/storage/ducklake_multi_file_reader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ DuckLakeMultiFileReader::~DuckLakeMultiFileReader() {
unique_ptr<MultiFileReader> DuckLakeMultiFileReader::Copy() const {
auto result = make_uniq<DuckLakeMultiFileReader>(read_info);
result->transaction_local_data = transaction_local_data;
return result;
return std::move(result);
}

unique_ptr<MultiFileReader> DuckLakeMultiFileReader::CreateInstance(const TableFunction &table_function) {
Expand Down
Loading