Use native string cast for ext composite types #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adjusts the `ResultSet#getString()` behaviour for columns
with composite types like `STRUCT` or `LIST` and also for extension
types. This method now delegates the cast to the native cast to
`VARCHAR`. When the extension (e.g. `spatial`) registers a cast for its
own types to `VARCHAR` - this cast now will be triggered.
In many cases, like `MAP`s, the resulting representation is the same.
But in some cases, like `spatial`'s `GEOMETRY` the resulting string now
can be correctly deserialized into its textual representation:
```
POINT (41.1 42.2)
```
instead of opaque (and useless one):
```
DuckDBBlobResult{buffer=java.nio.HeapByteBuffer[pos=0 lim=32 cap=32]}
```
Fixes: duckdb#298
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adjusts the
ResultSet#getString()behaviour for columns with composite types likeSTRUCTorLISTand also for extension types. This method now delegates the cast to the native cast toVARCHAR. When the extension (e.g.spatial) registers a cast for its own types toVARCHAR- this cast now will be triggered.In many cases, like
MAPs, the resulting representation is the same. But in some cases, likespatial'sGEOMETRYthe resulting string now can be correctly deserialized into its textual representation:instead of opaque (and useless one):
Fixes: #298