Skip to content

linearpart.h: Handle NaN NoData properly #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: Develop
Choose a base branch
from
Open

linearpart.h: Handle NaN NoData properly #264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/linearpart.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ class linearpart : public tdpartition {
int rank, size;
MPI_Datatype MPI_type;
datatype noData;
bool isNodataNan;
datatype *gridData;
datatype *topBorder;
datatype *bottomBorder;
Expand Down Expand Up @@ -136,6 +137,7 @@ void linearpart<datatype>::init(long totalx, long totaly, double dx_in, double d
dyA = dy_in;
MPI_type = MPIt;
noData = nd;
isNodataNan = isnan(noData);

//Allocate memory for data and fill with noData value. Catch exceptions
uint64_t prod; // use long 64 bit number to hold the product to allocate
Expand Down Expand Up @@ -473,11 +475,11 @@ bool linearpart<datatype>::isNodata(long inx, long iny){
x = inx;
y = iny;
//DGT to avoid nested calls and type inconsistency
if(x>=0 && x<nx && y>=0 && y<ny)return (abs((float)(gridData[x+y*nx]-noData))<MINEPS);
// if(isInPartition(x,y)) return (abs(gridData[x+y*nx]-noData)<MINEPS);
if(x>=0 && x<nx && y>=0 && y<ny)return (isNodataNan && isnan(gridData[x+y*nx])) || (!isNodataNan && abs((float)(gridData[x+y*nx]-noData))<MINEPS);
// if(isInPartition(x,y)) return (isNodataNan && isnan(gridData[x+y*nx])) || (!isNodataNan && abs(gridData[x+y*nx]-noData)<MINEPS);
else if(x>=0 && x<nx){
if(y==-1) return (abs((float)(topBorder[x]-noData))<MINEPS);
else if(y==ny) return (abs((float)(bottomBorder[x]-noData))<MINEPS);
if(y==-1) return (isNodataNan && isnan(topBorder[x])) || (!isNodataNan && abs((float)(topBorder[x]-noData))<MINEPS);
else if(y==ny) return (isNodataNan && isnan(bottomBorder[x])) || (!isNodataNan && abs((float)(bottomBorder[x]-noData))<MINEPS);
}
return true;
}
Expand Down