Allows to customize encoding type for the body #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If configuration value `only_encode_binary` is on, body will be encoded only if response is binary
|
I can create tests for this specific feature before PR merge if this proposal gets approved. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If configuration value
only_encode_binaryis true, response body will be encoded only if response is binary.Reason: I was trying to upgrade the version of "akamai-open/edgegrid-client" in https://github.com/akamai/NetStorageKit-PHP, but when I do
composer update, tests stop working, it looks likeguzzlehttp-vcrexpects response bodies to be base64 encoded and those from NetStorageKit-PHP are not. I could just encode all those response contents, but from what I could understand from https://github.com/php-vcr/php-vcr, only binary responses are base 64 encoded. So I think it would be good if we can turn off the encoding for non-binary content here.