Skip to content

Fixes for installation and usage in 2024 #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

twdragon
Copy link

  • Tested for a local run on Mint Linux 21.1 in 2024
  • Fixed dependency version conflicts
  • Returned with pretrained model files
  • Tested ONNX runtime

	- Tested for local run on Mint Linux 21.1 in 2024
	- Fixed dependency version conflicts
	- Returned with pretrained model files
	- Tested ONNX runtime
@dscripka
Copy link
Owner

Thanks for creating a PR! A few questions:

  1. What dependency conflict were you getting with the numpy specification, and what version of Python are you using? It seems to be passing tests correctly in the CI/CD pipelines.
  2. I removed the actual model files from the package as they take up space in the repository and make the pip package much larger. However, they can still be downloaded manually, or by using the openwakeword.utils.download_models() utility function. Are those options not working for your application of openWakeWord?

@twdragon
Copy link
Author

Thanks for creating a PR! A few questions:

  1. What dependency conflict were you getting with the numpy specification, and what version of Python are you using? It seems to be passing tests correctly in the CI/CD pipelines.
  2. I removed the actual model files from the package as they take up space in the repository and make the pip package much larger. However, they can still be downloaded manually, or by using the openwakeword.utils.download_models() utility function. Are those options not working for your application of openWakeWord?
  1. I use Python 3.10 on Mint Linux 21.1. I have just tried to install openwakeword and discovered a conflict for required numpy version between scipy and tflite, so I decided to change.
  2. Removal of the models is not a problem, we can exclude them from the PR. Would you like me to do that?

@dscripka
Copy link
Owner

Thanks for creating a PR! A few questions:

  1. What dependency conflict were you getting with the numpy specification, and what version of Python are you using? It seems to be passing tests correctly in the CI/CD pipelines.
  2. I removed the actual model files from the package as they take up space in the repository and make the pip package much larger. However, they can still be downloaded manually, or by using the openwakeword.utils.download_models() utility function. Are those options not working for your application of openWakeWord?
1. I use Python 3.10 on Mint Linux 21.1. I have just tried to install `openwakeword` and discovered a conflict for required `numpy` version between `scipy` and `tflite`, so I decided to change.

2. Removal of the models is not a problem, we can exclude them from the PR. Would you like me to do that?
  1. Could you share the details of conflict that you are getting? I'm also using Python 3.10 and don't seem to have that issue.
  2. Yes, if you could remove the files from the PR, that would be great.

@twdragon
Copy link
Author

twdragon commented Feb 8, 2025

@dscripka scipy may require installing numpy version later than 1.26 which is incompatible with tflite. To satisfy all the requirements, the numpy version should be between 1.23.2 and 1.25.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants