Skip to content

Fixed type errors in 'RemoteDesktopCollections' and 'RemoteDesktopDeployment' #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −13
Draft

Fixed type errors in 'RemoteDesktopCollections' and 'RemoteDesktopDeployment' #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4886db2
Removed 'skippedDscResources'
raandree Sep 11, 2022
365ac7c
Made 'SessionHost' a scalar as defined in the underlying DSC resource
raandree Sep 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,3 +79,4 @@ set to true when the LCM is already in ApplyAndAutoCorrect mode.
- ConfigurationManagerDeployment now has configurable Product Key.
- Made reading binary files in FilesAndFolders and CertificateImports more robust.
- Updated to latest version of 'PackageManagement' to fix module discovery error.
- Made 'SessionHost' a scalar as defined in the underlying DSC resource for 'RemoteDesktopCollections' and 'RemoteDesktopDeployment'.
6 changes: 3 additions & 3 deletions source/DSCResources/RemoteDesktopDeployment/RemoteDesktopDeployment.schema.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ configuration RemoteDesktopDeployment
$WebAccess,

[Parameter()]
[string[]]
$SessionHosts,
[string]
$SessionHost,

[Parameter()]
[hashtable[]]
Expand All @@ -26,7 +26,7 @@ configuration RemoteDesktopDeployment
{
ConnectionBroker = $ConnectionBroker
WebAccessServer = $WebAccess
SessionHost = $SessionHosts
SessionHost = $SessionHost
}

foreach ($gateway in $Gateways)
Expand Down
8 changes: 2 additions & 6 deletions tests/Unit/DSCResources/Assets/Config/RemoteDesktopCollections.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,10 @@
Collections:
- CollectionName: My first Collection
SessionHost:
- SH1
- SH2
SessionHost: SH1
CollectionDescription: This is my super awesome collection
ConnectionBroker: CB1
- CollectionName: My second Collection
SessionHost:
- SH1
- SH2
SessionHost: SH1
CollectionDescription: This is my super awesome collection number 2
ConnectionBroker: CB1
Settings:
Expand Down
4 changes: 1 addition & 3 deletions tests/Unit/DSCResources/Assets/Config/RemoteDesktopDeployment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
ConnectionBroker: CB1
SessionHosts:
- SH1
- SH2
SessionHost: SH1
WebAccess: WA1
2 changes: 1 addition & 1 deletion tests/Unit/DSCResources/DscResources.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ BeforeDiscovery {
$dscResources = Get-DscResource -Module $moduleUnderTest.Name
$here = $PSScriptRoot

$skippedDscResources = 'PowerShellRepositories', 'RemoteDesktopCollections', 'RemoteDesktopDeployment'
$skippedDscResources = ''

Import-Module -Name datum

Expand Down