Fix Sum type to_s with Dry::Struct types #485
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Sum type to_s with Dry::Struct types
Fixes #482
Problem
Sum types composed of two
Dry::Struct
types raiseNoMethodError: undefined method 'visit_sum_constructors'
when callingto_s
.Solution
Added missing
visit_sum_constructors
method to the Printer class that recursively handles sum type printing by visiting left and right branches.Changes
• Add
visit_sum_constructors
method that handles sum type decomposition• Add
visit_sum_constructor
helper method for recursive sum type handling• Add test coverage for sum types with
Dry::Struct
typesTesting