Skip to content

fix: [CI-17808]: Add old_drone_convert to support Harness v0 conversions #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: [CI-17808]: Add old_drone_convert to support Harness v0 conversions #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 29 additions & 10 deletions command/drone.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,16 +88,35 @@ func (c *Drone) Execute(_ context.Context, f *flag.FlagSet, _ ...interface{}) su
}

// convert the pipeline yaml from the drone
// format to the harness yaml format.
converter := drone.New(
drone.WithDockerhub(c.dockerConn),
drone.WithKubernetes(c.kubeName, c.kubeConn),
drone.WithOrgSecrets(orgSecrets...),
)
after, err := converter.ConvertBytes(before)
if err != nil {
log.Println(err)
return subcommands.ExitFailure
// convert the input yaml
var after []byte

// When downgrading is requested, use the OldConverter which produces output
// in a format compatible with the downgrader
if c.downgrade {
// Use the OldConverter implementation which is compatible with the downgrader
converter := drone.NewOld(
drone.WithKubernetes(c.kubeName, c.kubeConn),
drone.WithDockerhub(c.dockerConn),
drone.WithOrgSecrets(orgSecrets...),
)
after, err = converter.ConvertOld(bytes.NewReader(before))
if err != nil {
log.Println("Error using OldConverter:", err)
return subcommands.ExitFailure
}
} else {
// Use regular converter for non-downgrade path
converter := drone.New(
drone.WithKubernetes(c.kubeName, c.kubeConn),
drone.WithDockerhub(c.dockerConn),
drone.WithOrgSecrets(orgSecrets...),
)
after, err = converter.ConvertBytes(before)
if err != nil {
log.Println(err)
return subcommands.ExitFailure
}
}

// downgrade from the v1 harness yaml format
Expand Down
Loading