03 bank ocr only #33
Open
03 bank ocr only #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated fork
mettizik
reviewed
Nov 15, 2018
Collaborator
mettizik
left a comment
mettizik
left a comment
There was a problem hiding this comment.
В конечной реализации и списке тестов нету обработки отрицательных кейсов. Нет никаких претензий в плане того, что этого функционала пока нет, но в момент, когда появляются циклы, субстр и прочее (а в данном случае критерии валидности описаны в требованиях) сопутствующие негативные кейсы следует вносить в список
|
|
||
| /* | ||
| * Decomposition: | ||
| * - CompareDigit(const Digit& a, const Digit& b) -> bool - compares two digits, and returns true if it equals |
Collaborator
There was a problem hiding this comment.
Определять на этапе планирования интерфейсы функций не очень гуд - таким образом снижается эффект от очень важной фичи TDD проектирования кода исходя из потребностей. И если в данном случае, это не является проблемой в виду 4-х функций, на бОльших системах это может снижать удобство использования интерфейсов
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.