feat(rgba validation): allow floating point values for 0 and 1 on alpha channel #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This pull request enhances the alpha value validation in the
validateHTMLColorRgb
function by allowing floating-point representations of0.0
and1.0
. While the previous implementation already supported percentage values and general floating-point numbers, these updates ensure that the specific floating-point formats for0
and1
are explicitly accommodated.Changes Made:
0.0
and1.0
, along with their variations (0.00
,1.00
, etc.)Detailed Changes:
The regex segment for alpha value validation has been refined to:
This update allows for:
0.0
,0.00
, and1.0
,1.00
50%
,100%
)0.5
,0.75
)Testing:
The updated validation has been tested against various input cases to ensure its accuracy:
0
,0.0
,0.5
,1
,1.0
,50%
,100%
1.1
,-0.5
,200%
,1.01%
Impact:
This enhancement improves the robustness of the color validation logic by explicitly allowing floating-point representations of
0
and1
, ensuring better compliance with user expectations and CSS standards.Conclusion:
I believe this update will significantly enhance the usability of the RGB color parsing utility. I look forward to any feedback and further improvements!