Fix: WithPrometheus should bind client metrics #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

alienx5499 wants to merge 1 commit into drand:master from alienx5499:fix/with-prometheus-register

+7 −0

alienx5499 commented Oct 19, 2025

Summary

Implement metrics registration when a Prometheus registerer is provided via WithPrometheus.
Previously, WithPrometheus only stored the registerer and never bound metrics, acting as a no-op.

Changes

In client/client.go:
- Import github.com/drand/go-clients/internal/metrics.
- During client creation (makeClient), if cfg.prometheus != nil, call metrics.RegisterClientMetrics(cfg.prometheus) to bind all client metrics.

Why

Ensures WithPrometheus behaves as documented/expected and client metrics become observable/exported.

Testing

Ran go build ./... and go test ./...: all green..

Backward compatibility

No breaking changes; metrics registration is additive when a registerer is supplied.

Notes

Errors from duplicate registration are intentionally ignored at the call-site to allow registry reuse across multiple clients.

Closes #6


          client: register metrics when WithPrometheus is provided

de9ef23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet