Fix: Typo in manager address variable #424
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GarbageYard
force-pushed
the
seedclient-manager-fix
branch
from
73687d4 to
5803222
Compare
Signed-off-by: gaurav_chhabra <[email protected]>
GarbageYard
force-pushed
the
seedclient-manager-fix
branch
from
5803222 to
f19d880
Compare
GarbageYard
force-pushed
the
seedclient-manager-fix
branch
from
88151fc to
15856c6
Compare
Signed-off-by: gaurav_chhabra <[email protected]>
GarbageYard
force-pushed
the
seedclient-manager-fix
branch
from
15856c6 to
93877e3
Compare
|
Hi @gaius-qi, I’ve fixed the lint issue and signed off commits. Kindly re-review when convenient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typo in manager address variable
Description
I was trying to configure
seedClient.config.manager.addr: "10.1.49.7:31781"but it was not getting applied. On checking the filecharts/dragonfly/templates/seed-client/seed-client-configmap.yaml, it seems there's a typo.It should be
addrwithout the extrasin.Values.seedClient.config.manager.addrsMotivation and Context
This change is required so one could assign custom value for
addrin.Values.seedClient.config.manager