Skip to content

545 debug imagecomparison #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

545 debug imagecomparison #546

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd53ac4
Added debug code that writes expected and actual in addition to compa…
tbouchardMetabolon May 4, 2023
ab1f471
Moved the debug code to the outside of the match check. This way it w…
tbouchardMetabolon May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/main/java/com/dougnoel/sentinel/steps/ImageVerificationSteps.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,13 +134,23 @@ private static boolean checkIfImagesMatch(String elementName, boolean negate, St

//Write result to disk
boolean didTheyMatch = comparisonResult.getImageComparisonState() == ImageComparisonState.MATCH;
if(didTheyMatch == negate) {
if(didTheyMatch == negate)
FileManager.saveImage(outputFolder, failureImageName, comparisonResult.getResult());
}
else {
else
FileManager.saveImage(outputFolder, passedImageName, comparisonResult.getResult());

boolean debugBoolean = Configuration.toBoolean("debug");
if(debugBoolean) {
try {
FileManager.saveImage(outputFolder, imageId + "_" + "EXPECTED" + ".png", comparisonImage);
FileManager.saveImage(outputFolder, imageId + "_" + "ACTUAL" + ".png", currentStateImage);
}
catch(Exception e) {
String errorMessage = SentinelStringUtils.format("Debug mode was enabled, but an exception occurred parsing the setting. Ensure the passed value is 'true' or 'false'. Passed value {}. Exception {}", debugBoolean, e.getMessage());
log.error(errorMessage);
}
}

return didTheyMatch;
}

Expand Down