Skip to content

Avoid boxing booleans during tracing and when setting bool? properties #10884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

h3xds1nz
Copy link
Member

@h3xds1nz h3xds1nz commented May 26, 2025

This should be only merged after #10711 so we don't have to unnecessarily add the usings for KnownBoxes.

Gonna draft it for the same reason so that I can do an additional sweep once it is merged.

Description

Avoids boxing booleans in a few more cases than already done in #10628 and #10711.

I didn't opt-in for making a nullable<bool> helper for DPs as its not that prevalent and saves a few bytes.

Customer Impact

Less boxed booleans on the heap, less memory usage.

Regression

No.

Testing

Local build.

Risk

Low.

Microsoft Reviewers: Open in CodeFlow

@h3xds1nz h3xds1nz requested a review from a team as a code owner May 26, 2025 14:30
@h3xds1nz h3xds1nz marked this pull request as draft May 26, 2025 14:30
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels May 26, 2025
Copy link

codecov bot commented May 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 2.98817%. Comparing base (57fe8ac) to head (c6940aa).
Report is 10 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main     #10884          +/-   ##
===================================================
- Coverage   13.48885%   2.98817%   -10.50068%     
===================================================
  Files           3317       3319           +2     
  Lines         664749     664888         +139     
  Branches       74643      74674          +31     
===================================================
- Hits           89667      19868       -69799     
- Misses        572488     644839       +72351     
+ Partials        2594        181        -2413     
Flag Coverage Δ
Debug 2.98817% <0.00000%> (-10.50068%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution A label for all community Contributions draft PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant