Fix InvalidCastException in ComboBoxAutomationPeer / forward Scroll to ItemsControl #10877
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
InvalidCastException
inComboBoxAutomationPeer
which occurs becauseComboBoxAutomationPeer
nor its parents implementIScrollProvider
directly and hence the whole code block is just wrong as it will never work.We should use the
ItemsControlAutomationPeer
implementation to provide the interface viaScrollHost
/ScrollViewer
, which should be done only if the drop-down is open. See https://learn.microsoft.com/en-us/windows/win32/winauto/uiauto-supportcomboboxcontroltype.Reproduction steps are easy:
Customer Impact
Better performance and correct interface when the dropdown is open, improved accessibility.
Regression
Yes, this was introduced in #1278, guess the comment was misunderstood by the implementor and nobody bothered to check/test during review.
Testing
Local build, exploring the automation tree, ensuring the exception no longer happens.
Risk
Low.