[StyleCleanUp] Static holder types should be static or sealed (CA1052)

src/Microsoft.DotNet.Wpf/src/.editorconfig

@@ -17,9 +17,6 @@ csharp_style_pattern_matching_over_as_with_null_check = true:suggestion
 # CA1036: Override methods on comparable types
 dotnet_diagnostic.CA1036.severity = suggestion
 
-# CA1052: Static holder types should be Static or NotInheritable
-dotnet_diagnostic.CA1052.severity = suggestion
-
 # NOTE: If existing public API, CA1066 should be suppressed individually
 # in the GlobalSuppressions file.
 

src/Microsoft.DotNet.Wpf/src/Common/Graphics/wgx_core_types.cs

@@ -780,7 +780,7 @@ internal enum MILCMD
 #endif
 };
 
-    internal partial class DUCE
+    internal static partial class DUCE
     {
         //
         // The MILCE resource type enumeration.

src/Microsoft.DotNet.Wpf/src/PresentationCore/MS/Win32/UnsafeNativeMethodsPointer.cs

@@ -1,4 +1,4 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
 
@@ -14,7 +14,7 @@ namespace MS.Win32.Pointer
     /// For WM_POINTER <see cref="https://msdn.microsoft.com/en-us/library/windows/desktop/hh454916(v=vs.85).aspx"/>
     /// For InteractionContext <see cref="https://msdn.microsoft.com/en-us/library/windows/desktop/hh448840(v=vs.85).aspx"/>
     /// </summary>
-    internal class UnsafeNativeMethods
+    internal static class UnsafeNativeMethods
     {
         #region Enumerations
 

src/Microsoft.DotNet.Wpf/src/PresentationCore/MS/internal/Ink/InkSerializedFormat/Compress.cs

@@ -1,11 +1,11 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
 //#define OLD_ISF
 
 namespace MS.Internal.Ink.InkSerializedFormat
 {
-    internal class Compressor 
+    internal static class Compressor 
 #if OLD_ISF
         : IDisposable
 #endif

src/Microsoft.DotNet.Wpf/src/PresentationCore/MS/internal/MediaTrace.cs

@@ -1,4 +1,4 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
 namespace MS.Internal
@@ -25,7 +25,7 @@ internal class MediaTrace : IDisposable
         public static MediaTrace QueueItems = new MediaTrace("MILQueueItems");
         public static MediaTrace Statistics = new MediaTrace("Statistics");
 
-        public class ChangeQueue
+        public static class ChangeQueue
         {
             public static MediaTrace ApplyChange = new MediaTrace("Change queue: Apply Change");
             public static MediaTrace Enqueue = new MediaTrace("Change queue: Enqueue");

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/Stylus/Pointer/PointerStylusPointPropertyInfoHelper.cs

@@ -1,4 +1,4 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
 
@@ -9,7 +9,7 @@ namespace System.Windows.Input.StylusPointer
     /// <summary>
     /// Contains a WM_POINTER specific functions to parse out stylus property info
     /// </summary>
-    internal class PointerStylusPointPropertyInfoHelper
+    internal static class PointerStylusPointPropertyInfoHelper
     {
         #region Constants
 

src/Microsoft.DotNet.Wpf/src/PresentationFramework/MS/Internal/Annotations/Anchoring/TextSelectionHelper.cs

@@ -26,24 +26,9 @@ namespace MS.Internal.Annotations.Anchoring
     ///     represent these TextAnchors and can generate TextAnchors from
     ///     the locator parts.
     /// </summary>  
-    internal class TextSelectionHelper
+    internal static class TextSelectionHelper
     {
-        //------------------------------------------------------
-        //
-        //  Constructors
-        //
-        //------------------------------------------------------
-
-        #region Constructors
-
-        /// <summary>
-        /// This ctor is added to prevent the compiler from
-        /// generating a public default ctor. This class
-        /// should not be instantiated
-        /// </summary>
-        private TextSelectionHelper() { }
 
-        #endregion Constructors
 
         //------------------------------------------------------
         //

src/Microsoft.DotNet.Wpf/src/PresentationFramework/MS/Internal/Controls/ActiveXHelper.cs

@@ -1,4 +1,4 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
 //
@@ -19,7 +19,7 @@ namespace MS.Internal.Controls
     // It also has types that make sense only for ActiveX hosting classes.
     // In other words, this is a helper class for the ActiveX hosting classes.
     //
-    internal class ActiveXHelper
+    internal static class ActiveXHelper
     {
         //
         // Types:
@@ -56,11 +56,6 @@ public enum ActiveXState
         private static int logPixelsY = -1;
         private const int HMperInch = 2540;
 
-        // Prevent compiler from generating public CTOR
-        private ActiveXHelper()
-        {
-        }
-
         //
         // Static helper methods:
         //

src/Microsoft.DotNet.Wpf/src/PresentationFramework/MS/Internal/WindowsRuntime/Generated/WinRT/ExceptionHelpers.cs

@@ -372,7 +372,7 @@ internal static Exception GetExceptionForHR(this Exception innerException, int h
         }
     }
 
-    internal class ErrorStrings
+    internal static class ErrorStrings
     {
         internal static string Format(string format, params object[] args) => String.Format(format, args);
 

src/Microsoft.DotNet.Wpf/src/PresentationFramework/MS/Internal/WindowsRuntime/Generated/WinRT/Marshalers.cs

@@ -603,7 +603,7 @@ public static unsafe void DisposeAbiArray(object box)
         }
     }
 
-    internal class MarshalInterfaceHelper<T>
+    internal static class MarshalInterfaceHelper<T>
     {
         internal struct MarshalerArray
         {
@@ -974,7 +974,7 @@ public static unsafe void CopyManaged(object o, IntPtr dest, bool unwrapObject =
         public static unsafe void DisposeAbiArray(object box) => MarshalInterfaceHelper<object>.DisposeAbiArray(box);
     }
 
-    internal class Marshaler<T>
+    internal static class Marshaler<T>
     {
         static Marshaler()
         {

src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Documents/MsSpellCheckLib/RCW.cs

@@ -24,7 +24,7 @@ namespace System.Windows.Documents
 {
     namespace MsSpellCheckLib
     {
-        internal class RCW
+        internal static class RCW
         {
             #region WORDLIST_TYPE
 

src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Documents/TextTreeDumper.cs

@@ -1,4 +1,4 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
 //
@@ -16,22 +16,8 @@ namespace System.Windows.Documents
     //  TextTreeDumper.DumpTree(texttree);
     //  TextTreeDumper.DumpNode(someNode);
     //
-    internal class TextTreeDumper
+    internal static class TextTreeDumper
     {
-        //------------------------------------------------------
-        //
-        //  Constructors
-        //
-        //------------------------------------------------------
-
-    #region Constructors
-
-        // Static class.
-        private TextTreeDumper()
-        {
-        }
-
-        #endregion Constructors
 
         //------------------------------------------------------
         //

src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Markup/WpfXamlLoader.cs

@@ -12,7 +12,7 @@
 
 namespace System.Windows.Markup
 {
-    internal class WpfXamlLoader
+    internal static class WpfXamlLoader
     {
         private static Lazy<XamlMember> XmlSpace = new Lazy<XamlMember>(() => new WpfXamlMember(XmlAttributeProperties.XmlSpaceProperty, true));