Don't add -signed #2001
Draft
Don't add -signed #2001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This appears to cause some issues with loading external libraries due to new signature checks (?) added in October
ghost
approved these changes
Nov 3, 2024
ghost
approved these changes
Nov 13, 2024
ghost
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1995
This appears to cause some issues with loading external libraries due to new signature checks (?) added in October.
We now rename the unsigned one. Because the Microbuild signing process takes in the .VSIX and produces a new one. Its helpful to have both builds (as proven when only the signed one had issues) so I prefer to publish both, but we cant publish 2 artifacts with the same name.