-
Notifications
You must be signed in to change notification settings - Fork 395
Update package display format from package::version to package@version #9415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/10.0.2xx
Are you sure you want to change the base?
Conversation
…package@version Co-authored-by: marcpopMSFT <[email protected]>
Co-authored-by: marcpopMSFT <[email protected]>
@copilot can you fix these three tests for the change in the :: output to @?
|
…Tests Co-authored-by: marcpopMSFT <[email protected]>
Fixed the three tests to expect
Commit: Will be included in the progress report. |
I looked through all instances of :: in the sources and this covers all the ones I would expect to update for this. I don't know how to test the template repo and am relying on the automated tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't verify if any of these changes are correct. But if it doesn't cause problems in the SDK repo, then it is likely fine. But we'd have to wait for this to flow there to verify that.
InstallRequest.DisplayName
to use @ instead of ::NuGetManagedTemplatePackage.DisplayName
to use @ instead of ::Summary of Changes
Updated all package identifier and version display formatting from the legacy
package::version
format to the new recommendedpackage@version
format across:Core Properties:
InstallRequest.DisplayName
in Microsoft.TemplateEngine.AbstractionsNuGetManagedTemplatePackage.DisplayName
in Microsoft.TemplateEngine.EdgeException Messages:
PackageNotFoundException
constructorDownloadException
constructors (3 overloads)Logging Messages:
NugetApiPackageManager.cs
(5 locations)PackageManager.cs
test helper (3 locations)Console Output:
AdditionalDataExtensions.cs
in TemplateDiscovery toolsPackSourceChecker.cs
in TemplateDiscovery tools (12 locations)Tests:
NuGetInstallerTests.cs
(4 test assertions)TemplateDiscoveryTests.cs
(6 test assertions)Total: 10 files modified, 37 changes across the codebase. All references consistently updated to use the @ symbol instead of :: for package@version formatting.
Original prompt
Fixes #9414
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.